Your Digital Media Has Never Looked So Good

 
acreskey
Topic Author
Posts: 13
Joined: Wed Nov 30, 2016 6:06 pm

RAF.setAdUrl with package file

Thu Jul 13, 2017 1:34 pm

Hi,

Trying to set RAF.setAdUrl() with a local file (VMAP) but it's crashing inside RAF.
i.e.
#5  Function roku_ads_parser_parse(xmldata_ As String, adserver_ As String) As Object
   file/line: roku_ads_lib:/Roku_Ads_VAST_Parser.brs(190)


This is what I'm doing:
Note that the test of ReadAsciiFile() succeeds and outputs the file correctly.
file = "pkg:/config/ads.xml"

' test: succeeds
adXML = ReadAsciiFile(file)
? adXML

' crashes RAF
adInterface.setAdUrl(file)


The captured VMAP had been read processed by RAF previously, when retrieved via HTTP.
Any ideas?
 
User avatar
RokuNB
Posts: 183
Joined: Fri Mar 31, 2017 2:22 pm

Re: RAF.setAdUrl with package file

Thu Jul 13, 2017 8:25 pm

Tell me the firmware version, model #, RAF version.
Also give me a detailed error message, including the full stack (not only #5) and the exact error message (in other words copy&paste more context from the console). Showing the VMAP file may help too.
 
acreskey
Topic Author
Posts: 13
Joined: Wed Nov 30, 2016 6:06 pm

Re: RAF.setAdUrl with package file

Fri Jul 14, 2017 7:01 am

Sorry, this issue was "user error" on my part. The VMAP xml I used didn't parse.

However as a possible improvement the error-handling in the RAF VMAP parser could be improved to not crash :)

These are the logs:
Roku_Ads Framework version 2.0108


Roku_Ads_util_getStringFromUrl: requesting URL: pkg:/config/ads.xml

Suspending threads...
Thread selected:  1*   ...ib:/Roku_Ads_VAST_Parser.brs(190)    ??

Current Function:
182:  ??
183:  ??
184:  ??
185:  ??
186:  ??
187:  ??
188:  ??
189:  ??
190:* ??
191:  ??
Use of uninitialized variable. (runtime error &he9) in roku_ads_lib:/Roku_Ads_VAST_Parser.brs(190)
190: ??
Backtrace:
#5  Function roku_ads_parser_parse(xmldata_ As String, adserver_ As String) As Object
   file/line: roku_ads_lib:/Roku_Ads_VAST_Parser.brs(190)
#4  Function roku_ads_getads() As Dynamic
   file/line: roku_ads_lib:/Roku_Ads.brs(3966)

Local Variables:
No variable info.
Threads:
ID    Location                                Source Code

 1*   ...ib:/Roku_Ads_VAST_Parser.brs(190)    ??
  *selected
 
User avatar
RokuNB
Posts: 183
Joined: Fri Mar 31, 2017 2:22 pm

Re: RAF.setAdUrl with package file

Fri Jul 14, 2017 9:53 am

acreskey wrote:
However as a possible improvement the error-handling in the RAF VMAP parser could be improved to not crash :)

Absolutely. I just saw where the issue is and we'll plug it - thank you for the report and the details!
 
User avatar
RokuNB
Posts: 183
Joined: Fri Mar 31, 2017 2:22 pm

Re: RAF.setAdUrl with package file

Fri Jul 21, 2017 9:36 pm

And done - RAF 2.2 is out.

Who is online

Users browsing this forum: No registered users and 11 guests